Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test out Service::disarm for all tower services #434

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Test out Service::disarm for all tower services #434

wants to merge 3 commits into from

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Apr 3, 2020

LucioFranco
LucioFranco reviewed Apr 3, 2020
View reviewed changes
tower/src/ready_cache/cache.rs

// Take self.ready so we can call &mut self methods below
let mut ready = std::mem::take(&mut self.ready);
for (key, (mut svc, cancel)) in ready.drain(..) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch :(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... It's not expensive (like, it won't allocate for example), but it does mean that you might un-ready a bunch of services.

LucioFranco
LucioFranco reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall, I am just cautious about the panic for calling disarm wrong over just making it best effort?

I'd like @seanmonstar, @hawkw and @carllerche to take a look here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco left review comments

@seanmonstar seanmonstar Awaiting requested review from seanmonstar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonhoo @LucioFranco